this post was submitted on 20 Nov 2024
874 points (97.6% liked)
Programmer Humor
19817 readers
72 users here now
Welcome to Programmer Humor!
This is a place where you can post jokes, memes, humor, etc. related to programming!
For sharing awful code theres also Programming Horror.
Rules
- Keep content in english
- No advertisements
- Posts must be related to programming or programmer topics
founded 2 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
Skill issue
I don't know anything about programming, i came here from /all, but it seems to me that a command that's this permanently destructive warrants a second confirmation dialog message reminding the user that the files will be permanently deleted and not undoable
Here is the exact warning that a user had to click through in order to get to where they got:
That's not a very good dialog box. He didn't make any changes, so discarding them doesn't sound like a problem.
There should be a notice when you enable source control that this will permanently delete all existing files with a checkbox (checked by default) that says "Add existing files to source control."
~~He wouldn't have seen the "Discard Changes" button at all if source control wasn't already setup (and detected by VSCode).~~
~~No sane program will delete files when you initialize source control either.~~
As I found later, VSCode did have weird behaviors with source control back then. My experience is more with the latest versions.
My sibling ran into this issue once. I'm not sure if it's a setting or a default, but vscode would assume they were working in a blank repo until they made a commit.
Sounds like this person had the project (without source control) in another IDE, tried out VSCode, and it assumed that it was all 'changes'. I don't use VSCode, do I can't say for certain, but I know my sibling lost ~4 hours of project set up for the same reason (though they immediately realized it was their fault).
Reading your comment and #32459, I realize that VSCode source control did have some major issues back then.
It looks like they have improved though, as the latest VSCode I use doesn't auto-initialize repositories anymore.
Hm ok yeah, that seems quite scary sounding so that i would strongly hesitate before clicking on "discard ALL changes". Still, I wonder if a second confirmation dialog with more information is warranted for a command that's so destructive.
I wouldn't assume "discard changes" means "delete files that existed before the editor did".
It's changes from the prior commit in the repository, which, if they had not committed anything prior, would have been an empty directory.
This is perhaps a good lesson in teaching version control as its own concept rather than "streamlining it" by bundling it with an editor.
You shouldn't be taking ownership of files and then deleting them without communication a hell of a lot better than that.
I understand what happened. I'm saying that if you're going to delete stuff that was there before the software was, your flow to adding a project should include suggesting a base level commit of everything that's there already.
That's definitely fair, creating a repository in a non-empty directory could definitely suggest auto-committing the current state if it doesn't already. I don't use VSCode so I wouldn't know.
Although now that I think about it, that could have been the intention here but not automatic, if that's why 5k+ files were staged without the user explicitly staging them. Extra tragic if that's the case.
From the git discussions around the issue, it wasn't that the files were automatically staged, but that the "discard all changes" feature invoked a
git clean, and also deleted untracked files.Since OP's project wasn't tracked, it got detonated.
This is the biggest part of the problem. Using git directly, it just ignores files that aren’t tracked.
Ok then, the changes to the repository shouldve been discarded. Anything he uploaded shouldve been deleted from the server. Why were files on his local machine deleted?
The repository in Git isn't on the server, it's on your local machine.
What makes you think a server was involved here? It was a local repository, evidenced by the reporter's bewilderment that files can be deleted without going to the Recycle Bin first. Which tells us that in addition to VCS, they were unfamiliar with Windows as well.
Admittedly i dont use source control myself as im a hobbiest, but I didnt realize that git was local. As for the recycle bin bit, yeah theyre kinda dumb. Is source control different from git?
Hobbyist myself so no worries! Git is one example of source control / version control software. You normally have your local working copy of a repository and then a remote where you push your changes when they are finished or to share them with others.
You may be confusing git with GitHub.
git is a version control tool that lets you keep and manage a history of the files you are editing
GitHub is a website (not directly affiliated with the group maintaining git) that lets you upload, backup, and share your code using the format used by the git tool.
source control just refers to software to manage your source code in some form. git is the most popular tool of its kind, but there are others, for example mercurial.
It's not that. It means discard all changes made after the last change committed to this local repository.
In this case it seems like it also performed a
git cleanand deleted his untracked files too. Someone actually opened a an issue to try and prevent the behaviour in the futurediscarding changes does not discard uncommitted new files. The VS Code button did a
git cleanwhich is completely unexpected. Git even refers to a git clean with completely different terminology.Note that git clean never once refers to discarding anything, and git reset never refers to removing untracked files. VS Code was doing an idiotic thing. Running
git reset --hardANDgit clean. There is absolutely no reason to be runninggit cleanfrom an UI button ever. If you want to remove a file you can explicitly remove it.Imagine that the button said "Discard all changes" and then it ran
rm -rf --no-preserve-root /*. Would that make sense as a button? No. It definitely would not.or like "unmount d:" but instead it formats d:
Which is exactly the situation the dude was in. As a newbie, it's an easy mistake to make. Telling somebody who doesn't know "well, would you look at that, you didn't know!" is not just unhelpful, it's useless and condescending.
Anti Commercial-AI license
I guess cancelling would go back to the "Then you want to commit all files?" dialog, which the user didn't want to, he just wanted to cancel whatever the IDE was trying to start.
The problem is that these are “source control basics” that everyone needs to learn the hard way once it seems.
Waiting 3 months in between commits however is a really bad rookie mistake because you were worried about making a commit that wasn’t perfect.
the problem is that VS Code ran
git cleanif you clicked yes, which is completely idiotic behavior. No other git client, text editor, or IDE on the planet does that.Either way, waiting 3 months worth of work before a commit is the big mistake here.
I think they hadn't ever used git before, and according to at least one person in the linked issue, vs code might have auto initialized the git repository for the user.
In fairness, ALL git terms feel backwards at first.
Imperfect commits never existed when you squash.
Interesting. I wouldn't know, because I code everything perfectly the first time.
Disclaimer: The above flagrant lie was brought to you by my also using rebase and squash to hide all of my mistakes.
Squash ftw. Simpler clearer history.
They clicked discard changes, confirmed it, and the computer did as instructed. This operation is normally not so destructive as it only discards uncommitted changes to realign the local directory with the remote server. Unfortunately for user, it sounds like they have never committed a change, so realignment meant reverting to an empty folder.
I think it’s important to know that this program is for code developers, and the issue here is with a tool called git. Git is like file saving on steroids, because on top of saving a single file, you save many changes to files in git, add a comment for why you made those changes, and share your changes across dozens of files with other developers.
What this guy did was develop for many months after starting to use git, but he never actually committed the files. Then he asked for to reset everything back to the original state, something that I do multiple times a day, and it gave him a warning that original means original and you will lose everything. And he said do it anyways.
No he asked for a discard after importing the project into VS Code. discard in git terms refers to
git reset, notgit clean. Even if he wanted to run agit resetthen this version of VS Code would have run agit cleanand deleted everything. Imagine he committed all 5000 files, but had a secret.json that he hadn't committed. He didn't add it to gitignore either. Running agit reset --hardwill not delete this file, but the VS Code button did exactly that because it ran agit clean.Perhaps. Still I am not sure why someone who is not aware of this would be using VSC. If they are a student then what kind of project are they working on that they have so many files?
I'm sure 99% of the files were node modules. The npm bloat is real.
That is wild.