this post was submitted on 29 Aug 2024
504 points (98.5% liked)

Linux

47994 readers
1563 users here now

From Wikipedia, the free encyclopedia

Linux is a family of open source Unix-like operating systems based on the Linux kernel, an operating system kernel first released on September 17, 1991 by Linus Torvalds. Linux is typically packaged in a Linux distribution (or distro for short).

Distributions include the Linux kernel and supporting system software and libraries, many of which are provided by the GNU Project. Many Linux distributions use the word "Linux" in their name, but the Free Software Foundation uses the name GNU/Linux to emphasize the importance of GNU software, causing some controversy.

Rules

Related Communities

Community icon by Alpár-Etele Méder, licensed under CC BY 3.0

founded 5 years ago
MODERATORS
 

Wedson Almeida Filho is a Microsoft engineer who has been prolific in his contributions to the Rust for the Linux kernel code over the past several years. Wedson has worked on many Rust Linux kernel features and even did a experimental EXT2 file-system driver port to Rust. But he's had enough and is now stepping away from the Rust for Linux efforts.

From Wedon's post on the kernel mailing list:

I am retiring from the project. After almost 4 years, I find myself lacking the energy and enthusiasm I once had to respond to some of the nontechnical nonsense, so it's best to leave it up to those who still have it in them.

...

I truly believe the future of kernels is with memory-safe languages. I am no visionary but if Linux doesn't internalize this, I'm afraid some other kernel will do to it what it did to Unix.

Lastly, I'll leave a small, 3min 30s, sample for context here: https://youtu.be/WiPp9YEBV0Q?t=1529 -- and to reiterate, no one is trying force anyone else to learn Rust nor prevent refactorings of C code."

you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 3 points 2 months ago (6 children)

C is crap for anything where security matters. I'll happily take that debate with anyone who thinks differently.

[–] [email protected] 43 points 2 months ago* (last edited 2 months ago) (3 children)

No idea what you’re being downvoted. Just take a look at all the critical CVSS scored vulnerabilities in the Linux kernel over the past decade. They’re all overwhelmingly due to pitfalls of the C language - they’re rarely architectural issues but instead because some extra fluff wasn’t added to double check the size of an int or a struct etc resulting in memory corruption. Use after frees, out of bounds reads, etc.

These are pretty much wiped out entirely by Rust and caught at compile time (or at runtime with a panic).

The cognitive load of writing safe C, and the volume of extra code it requires, is the problem of C.

You can write safe C, if you know what you’re doing (but as shown by the volume of vulns, even the world’s best C programmers still make slip ups).

Rust forces safe(r) code without any of the cognitive load of C and without having to go out of your way to learn it and religiously implement it.

[–] qqq 21 points 2 months ago* (last edited 2 months ago) (1 children)

They're being downvoted because it's a silly comment that is basically unrelated and also extremely unhelpful. Everyone can agree that C has footguns and isn't memory safe, but writing a kernel isn't memory safe. A kernel written in Rust will have tons of unsafe, just look at Redox: https://github.com/search?q=repo%3Aredox-os%2Fkernel%20unsafe&type=code That doesn't mean it isn't safer, even in kernel space, but the issues with introducing Rust into the kernel, which is already written in C and a massive project, are more nuanced than "C bad". The religious "C bad" and "C good" arguments are kinda exactly the issue on display in the OP.

I say this as someone who writes mostly Rust instead of C and is in favor of Rust in the kernel.

[–] [email protected] 8 points 2 months ago (1 children)

The difference is that now you have a scope of where the memory unsafe code might be(unsafe keyword) and you look there instead of all the C code.

[–] qqq 2 points 2 months ago* (last edited 2 months ago)

I agree and think that should be helpful, but I hesitate to say how much easier that actually makes writing sound unsafe code. I'd think most experienced C developers also implicitly know when they're doing unsafe things, with or without an unsafe block in the language -- although I think the explicit unsafe should likely help code reviewers and tired developers.

It is possible to write highly unsafe code in Rust while each individual unsafe block appears sound. As a simple example: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=6a1428d9cae5b9343b464709573648b4 [1] Run that on Debug and Release builds. Notice the output is different? Don't take that example as some sort of difficult case, you wouldn't write this code, but the concepts in it are a bit worrisome. That code is a silly example, but each individual unsafe block appears sound when trying to reason only within the block. There is unsafe behavior happening outside of the unsafe blocks (the do_some_things function should raise eyebrows), and the function we ultimately end up in has no idea something unsafe has happened.

Unsafe code in Rust is not easy, and to some extent it breaks abstractions (maybe pointers in general break abstractions to some extent?). noaliases in that playground code rightly assumes you can't have a &ref and &mut ref to the same thing, that's undefined behavior in Rust. Yet to understand the cause of that bug you have to look at all function calls on the way, just as you would have to in C, and one of the biggest issues in the code exists outside of an unsafe block.

[1]: If you don't want to click that link or it breaks, here is the code:

fn uhoh() {
    let val = 9;
    let val_ptr: *const usize = &val;
    do_some_things(val_ptr);
    println!("{}", val);
}

fn do_some_things(val: *const usize) {
    let valref = unsafe { val.as_ref().unwrap() };
    let mut_ptr: *mut usize = val as *mut usize;
    do_some_other_things(mut_ptr, valref);
}

fn do_some_other_things(val: *mut usize, normalref: &usize) {
    let mutref = unsafe { val.as_mut().unwrap() };
    noaliases(normalref, mutref);
}

fn noaliases(input: &usize, output: &mut usize) {
    if *input < 10 {
        *output = 15;
    }
    if *input > 10 {
        *output = 5;
    }
}

fn main() {
    uhoh();
}
[–] [email protected] -4 points 2 months ago

having to go out of your way to learn it and religiously implement it.

Look! I painted the mona lisa in ketchup.

[–] [email protected] 24 points 2 months ago (3 children)

I think most people would agree with you, but that isn't really the issue. Rather the question is where the threshold for rewriting in Rust vs maintaining in C lies. Rewriting in any language is costly and error-prone, so at what point do the benefits outweigh that cost and risk? For a legacy, battle-tested codebase (possibly one of the most widely tested codebases out there), the benefit is probably on the lower side.

[–] [email protected] 18 points 2 months ago (1 children)

Isn't that exactly the strawman the maintainer got tired of?

[–] [email protected] 3 points 2 months ago (1 children)

Hmm... I admit I didn't follow the video and who was speaking very well and didn't notice hostility that others seem to pick up on. I've worked with plenty of people who turn childish when a technical discussion doesn't go their way, and I've had the luxury of mostly ignoring them, I guess.

It sounded like he was asking for deeper specification than others were willing or able to provide. That's a constant stalemate in software development. He's right to push for better specs, but if there aren't any then they have to work with what they've got.

My first response here was responding to the direct comparison of languages, which is kind of apples and oranges in this context, and I guess the languages involved aren't even really the issue.

[–] pivot_root 11 points 2 months ago* (last edited 2 months ago) (1 children)

Part of the hostility was the other maintainer misunderstanding the presenter, going on a diatribe about how the kernel Rust maintainers are going to force the C code to become unrefactorable and stagnate, and rudely interrupting the presenter with another tangent whenever he (the presenter) tried to clarify anything.

An unpleasant mix of DM railroading and gish galloping, essentially.

~~I wouldn't quite call it a strawman, but~~ the guy was clearly not engaging in good faith. He made up hypothetical scenarios that nobody asked about, and then denigrated Rust by attacking the scenarios he came up with.

Edit: I was thinking of the wrong fallacy. It is a strawman, yes.

[–] [email protected] 5 points 2 months ago (1 children)

He made up hypothetical scenarios that nobody asked about, and then denigrated Rust by attacking the scenarios he came up with.

This seems to be the textbook description of a strawman argument.

[–] pivot_root 5 points 2 months ago

Wait, yeah. I was thinking of ad hominem when i wrote that, sorry. Correct, that is a strawman.

[–] Bookmeat 6 points 2 months ago

If the timeline is long enough then it's always worth the refactor.

[–] [email protected] 2 points 2 months ago

Seeing as how 40% of the security issues that have been found over the years wouldn't exist in a memory-safe language, I would say a re-write is extremely worth it.

[–] [email protected] 21 points 2 months ago* (last edited 1 month ago) (2 children)

[This comment has been deleted by an automated system]

[–] [email protected] 16 points 2 months ago (1 children)

Agree. I'm an absolutely awesome software dev myself - and I know C by heart (being my favorite language after assembler). However, with age comes humility and the ability to recognize that I will write buggy code every now and then.

Better the language saves me when I can't, in security critical situations.

[–] [email protected] 1 points 2 months ago

Even if you manage to keep all memory accesses in your memory, while writing the code, there's a good chance you'll forget something when reviewing another person's MR. That's probably the main problem creator.

Still, a language that you are familiar with, is better than a new language that you haven't finished reading the specifications of. And considering that adding new maintainers comes with a major effort of verifying trustworthiness, I get how it would be harder to switch.

[–] [email protected] 6 points 2 months ago (1 children)

such a weird dichotomy in Windows – secure kernel space and privacy-nightmare user space … “we’re the only ones allowed to steal your data”

[–] [email protected] 12 points 2 months ago

Maybe when you build some little application or whatever. When building the most used kernel in the world, there are probably some considerations that very few people can even try to understand.

[–] [email protected] 11 points 2 months ago (1 children)

What debate? You offered zero arguments and "C bad tho" isn't one.

[–] [email protected] -3 points 2 months ago (1 children)

Do you believe C isn't crap when it comes to security? Please explain why and I'll happily debate you.

/fw hacker, reverse engineer

[–] [email protected] 0 points 2 months ago (1 children)

That's not how it works. You said:

C is crap for anything where security matters.

Argue for your point.

[–] [email protected] 3 points 2 months ago (2 children)
[–] [email protected] 2 points 2 months ago (1 children)

Lots of categories which Rust doesn't prevent, and in the kernel you'll end up with a lot of unsafe Rust, so it can't guarantee memory-safety in all cases.

[–] [email protected] 5 points 2 months ago

The biggest items on the graph are all out of bounds accesses, use-after-free and overflows. It is undeniable that memory safe languages help reducing vulnerabilities, we know for decades that memory corruption vulnerabilities are both the most common and the most severe in programs written in memory-unsafe languages.

Unsafe rust is also not turning off every safety feature, and it's much better to have clear highlighted and isolated parts of code that are unsafe, which can be more easily reviewed and tested, compared to everything suffering from those problems.

I don't think there is debate here, rewriting is a huge effort, but the fact that using C is prone to memory corruption vulnerabilities and memory-safe languages are better from that regard is a fact.

[–] [email protected] -5 points 2 months ago (1 children)

Link dropping is also not arguing.

[–] [email protected] 5 points 2 months ago (2 children)

Citing scientific research is. Now, please post your gut feeling in response.

[–] [email protected] 8 points 2 months ago

My gut feeling is you didn't hook a programmer but a debate pervert (maybe shouldn't have dropped the D word lol). Some people hear that word and turn they minds off cuz debates are simply a game for them to win. I'd just let this one swim brother

[–] [email protected] 6 points 2 months ago (1 children)

C is crap for anything where security matters.

True for people misusing it. If you want to argue the ease of mis-use, it's a fun talk.

[–] MotoAsh 10 points 2 months ago* (last edited 2 months ago)

Yea, it's not C that is crap, but that it has zero guard rails. Like blaming a knife for not having a guard... Is it a bad knife without a guard? Depends on how sharp it is. The guard is orthogonal to the knife's purpose, but might still be important when the knife is used.

Just because something doesn't help prevent accidents does not mean it cannot serve its actual purpose well, unless its actual purpose is safety.