Post funny things about programming here! (Or just rant about your favourite programming language.)
public class GameManager : MonoBehaviour
{
public bool EnableHighContrast;
public bool PlayerWon;
public float PlayerUnitsMoved;
public int PlayerDeathCount;
public float PlayerHealth;
public void PlayerTakeDamage(float damage)
{
PlayerHealth -= damage;
if (PlayerHealth < 0)
{
PlayerDieAndRespawn();
}
}
public void PlayerDieAndRespawn()
{
return;
}
}
I couldn't contain myself.
Should it be
PlayerHealth <= 0
?
Otherwise the player could have 0 health and not die? I’m sleep deprived so forgive me if I’m wrong
Open up ticket first, please. Thanks Codemonkey.
You are correct.
Counting this meme as my first FOSS contribution
Holy shit I was there with you sir! With the zeros and stuff
You are correct about it allowing you to have zero health and not die, but whether or not that's the correct behavior will depend on the game. Off the top of my head I know that Street Fighter, some versions at least, let you cling to life at zero.
Yay, escaped the fight with 0 health!
Well if you have a "down but not dead" condition then yes, you could escape a fight with 0 health (assuming you have teammates/pawns that can save you).
I called the takeDamage function and my player disappeared: send 'elp everything foobar
Don't worry! this issue will be fixed in the next patch. In the meantime just try not getting hit.
Great. Now that my code is self-documenting it is somehow also not legible?
Make up your damn minds, peeps!
Is this... clean code ? 💁♂️ 🦋
gestures at ~~butterfly~~ this code
Is this self-documenting code?
I genuinely believe something like this is what some of my professors wanted me to submit back in school. I once got a couple points off a project for not having a clarifying comment on every single line of code. I got points off once for not comment-clarifying a fucking iterator variable. I wish I could see what they would have said if I turned in something like this. I have a weird feeling that this file would have received full marks.
Did you have my professor for intro to C? This guy was well known for failing people for plagiarism on projects where the task was basically "hello world". And he disallowed using if/else for the first month of class.
This is something that can easily get refactored, because the purpose of alia the variables is right there in the name. This is way better that spending three days to try to figure out what the purpose of var1 is.
Nah, refactoring this would be a bitch. Your function name contains everything that happens in the function. Which means if you add something to it, you also have to change the name of the function. So CallThisWhenThePlayerTakesDamageAndIfThePlayerHealthIsLessThanZeroThenAlsoTheyDie would have to go to something like CallThisWhenThePlayerTakesDamageAndIfThePlayerHealthIsLessThanZeroThenAlsoTheyDieAndIncrementTheTotalDamageTakenCounter if you added something else.
IDE renames all references, no issue
oh such hope
in a week IntegerThatTracksOneThingForOnePurpose will be an object tracking 30% of the game state and mutated in 15 places without ever being renamed
I would take this over int a; anyday
Amateur! Ints should be called i, j or k.
int IntegerThatWillBeUsedToIterateOverAListOfItemsAndModifyThem2
I mean, this is overdoing it a bit and the "thisVarMakesItSoThat" part is redundant, but other than that those are very descriptive property- and method names, which is not a bad thing.
It wouldn't need to say HighContrastForAccessibilityPurposes though, it would ideally just be HighContrast, and the "for accessibility purposes" would be a comment, right?
Variable names shouldn't need comments, period. You don't want to look it up every time this variable is used in code, just to understand what it holds. Of course there are always exceptions, but generally names should be descriptive enough to not need additional explanation.
And context can also come from names of other things, e.g. name of a class / namespace that holds this variable. For example AccessibilitySettings.HighContrast, where AccessibilitySettings holds all options related to accessibility.
Well the "Purposes" can definitly be dropped. I guess "HighContrast" would be enough if there is only a single high contrast setting, but if there are multiple then I think "HighContrastForAccessibility" would be totally fine.
Deobfuscated code
yeah, PascalCase is the worst
I'll take this over the more "classic" styles, when people seed to believe they were paying the compiler by the character.
I respect code golfers the same way I respect a cobra, from a distance. Don't bring that single character naming to the codebase please.
Self documenting!
Starting my day off with this absolutely cursed image, thank you OP.
Looks ugly until you need to implement something and realize you've been blessed with a description of business logic.
Strong names are great, but (sometimes) mentioning the type of variable in the name is redundant.
The real naming fail is calling the class "GameManager", still my number one pet peeve. With a class name as vague as that you would have to add tons of information into the variable name. (Also the class name begs for unorganized code. I mean name one function or variable that you could not justify putting into the "GameManager" class. After all if it's managing the game it could justifiably perform any process in the game and access any state in it.)
Once you put the first bool into a class with a name like AccessibilitySettings, calling it something like HighContrast is completely sufficient.
Bruh didn't know how to use comments to describe a function or variable...
Clearly this is what we call "self documenting code".
"Commenting is for n00bs"
You forgot to declare custom primitive types. You cannot create a bool you gotta declare a DoubleYouDoubleYouDoubleYouDotLemmyGradDotML_Bool
Self-explanatory code doesn't need comments!
I see. So that’s why people put comments before variable declarations.
Like... there's such a thing as comments my dude.