this post was submitted on 06 Jul 2024
473 points (94.0% liked)

Privacy

32173 readers
202 users here now

A place to discuss privacy and freedom in the digital world.

Privacy has become a very important issue in modern society, with companies and governments constantly abusing their power, more and more people are waking up to the importance of digital privacy.

In this community everyone is welcome to post links and discuss topics related to privacy.

Some Rules

Related communities

much thanks to @gary_host_laptop for the logo design :)

founded 5 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
[–] x1gma 82 points 5 months ago* (last edited 5 months ago) (5 children)

How in the fuck are people actually defending signal for this, and with stupid arguments such as windows is compromised out of the box?

You. Don't. Store. Secrets. In. Plaintext.

There is no circumstance where an app should store its secrets in plaintext, and there is no secret which should be stored in plaintext. Especially since this is not some random dudes random project, but a messenger claiming to be secure.

Edit: "If you got malware then this is a problem anyway and not only for signal" - no, because if secure means to store secrets are used, than they are encrypted or not easily accessible to the malware, and require way more resources to obtain. In this case, someone would only need to start a process on your machine. No further exploits, no malicious signatures, no privilege escalations.

"you need device access to exploit this" - There is no exploiting, just reading a file.

[–] [email protected] 43 points 5 months ago (3 children)

You. Don't. Store. Secrets. In. Plaintext.

SSH stores the secret keys in plaintext too. In a home dir accessible only by the owning user.

I won't speak about Windows but on Linux and other Unix systems the presumption is that if your home dir is compromised you're fucked anyway. Effort should be spent on actually protecting access to the home personal files not on security theater.

[–] x1gma 9 points 5 months ago

Kinda expected the SSH key argument. The difference is the average user group.

The average dude with a SSH key that's used for more than their RPi knows a bit about security, encryption and opsec. They would have a passphrase and/or hardening mechanisms for their system and network in place. They know their risks and potential attack vectors.

The average dude who downloads a desktop app for a messenger that advertises to be secure and E2EE encrypted probably won't assume that any process might just wire tap their whole "encrypted" communications.

Let's not forget that the threat model has changed by a lot in the last years, and a lot of effort went into providing additional security measures and best practices. Using a secure credential store, additional encryption and not storing plaintext secrets are a few simple ones of those. And sure, on Linux the SSH key is still a plaintext file. But it's a deliberate decision of you to keep it as plaintext. You can at least encrypt with a passphrase. You can use the actual working file permission model of Linux and SSH will refuse to use your key with loose permissions. You would do the same on Windows and Mac and use a credential store and an agent to securely store and use your keys.

Just because your SSH key is a plaintext file and the presumption of a secure home dir, you still wouldn't do a ~/passwords.txt.

[–] [email protected] 8 points 5 months ago (3 children)

Not true, SSH keys need their passphrase to be used. If you don't set one, that's on you.

[–] [email protected] 17 points 5 months ago* (last edited 5 months ago) (1 children)

Come on, 95% of users don't set passwords on their ssh keys

[–] idunnololz 5 points 5 months ago (1 children)

Where are these stays from lmao.

[–] [email protected] 5 points 5 months ago (1 children)
[–] [email protected] 4 points 5 months ago

You can count me too

[–] [email protected] 10 points 5 months ago

Well yes, but also how would users react if they had to type in their passphrase every time they open the app? This is also exactly what we're giving up everywhere else by clicking 'remember this device'.

[–] [email protected] 2 points 5 months ago

If someone gets access they can delete your keys, or set up something that can intercept your keys in other ways.

The security of data at rest is just one piece of the puzzle. In many systems the access to the data is considered much more important than whether the data itself is encrypted in one particular scenario.

[–] [email protected] 0 points 5 months ago

SSH has encrypted keys

[–] [email protected] 16 points 5 months ago (1 children)

If someone has access to your machine you are screwed anyway. You need to store the encryption key somewhere

[–] x1gma -1 points 5 months ago* (last edited 5 months ago)

Yes, in your head, and in your second factor, if possible, keeping derived secrets always encrypted at rest, decrypting at the latest possible moment and not storing (decrypted) secrets in-memory for longer than absolutely necessary at use.

[–] [email protected] 12 points 5 months ago* (last edited 5 months ago) (2 children)

How in the fuck are people actually defending signal for this

Probably because Android (at least) already uses file-based encryption, and the files stored by apps are not readable by other apps anyways.

And if people had to type in a password every time they started the app, they just wouldn't use it.

[–] [email protected] 19 points 5 months ago (1 children)

Popular encrypted messaging app Signal is facing criticism over a security issue in its desktop application.

Emphasis mine.

[–] ChapulinColorado 13 points 5 months ago (1 children)

I think the point is the developers might have just migrated the code without adjustments since that is how it was implemented before. Similar to how PC game ports sometimes run like shit since they are a close 1-1 of the original which is not always the most optimized or ideal, but the quickest to output.

[–] x1gma 6 points 5 months ago

Been a few days since using electron, but AFAIK electron can't be used as a wrapper for android apps, or can it? Or is their android app a web app wrapped into a "native" android app too?

Also, since this seems to be an issue since 2018, 6 years should be plenty to rewrite using a native secure storage...

[–] [email protected] 2 points 5 months ago

AFAIK Android encrypts entire fs with one key. And ACL is not encryption.

[–] [email protected] 6 points 5 months ago

You. Don't. Store. Secrets. In. Plaintext.

Ok. Enter password at every launch.

[–] [email protected] 1 points 5 months ago (1 children)

All your session cookies are stored in plaintext.

[–] x1gma 1 points 5 months ago

Chrome cookies are encrypted, for exactly the reasons stated. If malware gains access to your system and compromises it in a way that DPAPI calls can be replicated in the way Chrome does it, then your sessions will also be compromised. But this is way harder to do, and at least prevents trivial data exfiltration.