Godot

5972 readers

111 users here now

Welcome to the programming.dev Godot community!

This is a place where you can discuss about anything relating to the Godot game engine. Feel free to ask questions, post tutorials, show off your godot game, etc.

Make sure to follow the Godot CoC while chatting

We have a matrix room that can be used for chatting with other members of the community here

Other Communities

Rules

Posts need to be in english
Posts with explicit content must be tagged with nsfw
We do not condone harassment inside the community as well as trolling or equivalent behaviour
Do not post illegal materials or post things encouraging actions such as pirating games

We have a four strike system in this community where you get warned the first time you break a rule, then given a week ban, then given a year ban, then a permanent ban. Certain actions may bypass this and go straight to permanent ban if severe enough and done with malicious intent

Wormhole

[email protected]

Credits

The icon is a modified version of the official godot engine logo (changing the colors to a gradient and black background)
The banner is from Godot Design

founded 2 years ago

MODERATORS

[email protected]

Implementing triggered abilities (self.godot)

submitted 6 months ago by Jozzo to c/[email protected]

6 comments fedilink hide all child comments

For character abilities that have a certain trigger condition, eg. "OnAttack", "OnJump", "OnDamaged" etc..

Currently each of these triggers is a signal. When a signal fires, the character loops through all of its abilities and activates each one with that specific condition, so it just runs an if statement for every ability, regardless of whether it has that condition or not:

if ability.trigger_condition == Triggers.OnAttack:
  ability.activate()

My issue is that this could get a little unscalable with many characters on-screen each having many abilities of their own. A character could have 1 OnDamaged ability and 19 OnAttack abilities, but when an "OnDamaged" signal is received, it will still loop through all 19 OnAttack abilities.

Any advice on this is appreciated, thank you all.

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 2 points 6 months ago

It's hard to give advice about how code should be structured, since there's many ways of accomplishing the same things, but you're doing the right thing by thinking about scalability before you get too deep to change it.

You could try separating eacg trigger condition into their own functions, so that if an OnAttack gets triggered it will only check and loop through OnAttack abilities.

Something like:

OnAttack.connect( CheckOnAttack )
OnDamaged.connect( CheckOnDamaged )

func CheckOnAttack( ATTACK_TYPE ):
          match ATTACK_TYPE:
                  ....

func CheckOnDamaged( DAMAGE_TYPE ):
         match DAMAGE_TYPE:
                  ....

Godot

Links

Other Communities

Rules

Wormhole

Credits