this post was submitted on 18 Oct 2023

341 points (96.2% liked)

Programmer Humor

32371 readers

644 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

Posts must be relevant to programming, programmers, or computer science.
No NSFW content.
Jokes must be in good taste. No hate speech, bigotry, etc.

founded 5 years ago

MODERATORS

[email protected]

341

Me, migrating my code from JavaScript to TypeScript: (lemmy.world)

submitted 1 year ago by callmepk to c/[email protected]

28 comments fedilink hide all child comments

all 33 comments

sorted by: hot top controversial new old

[+] folkrav 85 points 1 year ago* (last edited 1 year ago) (5 children)

[deleted]

[–] PoopMonster 43 points 1 year ago (2 children)

Just as irritating as seeing people use linters only to have a lot of files with @ts-ignore all over the place... Like why even bother?

[–] [email protected] 8 points 1 year ago

oh you've got a private variable that I want to use? No worries, (foo as any)['secret'].

[–] [email protected] 3 points 1 year ago* (last edited 1 year ago)

I’ve literally just put ts-ignore in many many files. The reason was legacy stuff, we had the ts check off (which blocks a merge if it failed), because there were just too many files that would need fixing. We thought about the best way to add the check so that new files have to have proper types, while having an easy way to slowly fix old ones.

We decided to go with ts-ignore for every file and a lint warning for the same line. So you see it in each file if it needs to be fixed, but you’re not going blind for red ts errors everywhere or don’t have the check at all.

[–] fusio 12 points 1 year ago

using any is actually much worse than using TS, because you're basically telling the compiler "don't help me here".. at least with JS the IDE is gonna help you.. :/

[–] [email protected] 10 points 1 year ago

That's the joke

[–] [email protected] 3 points 1 year ago (1 children)

tbh I don't remember why I'm using TypeScript

[–] [email protected] 3 points 1 year ago (1 children)

I don't follow, stamping every function with : any lets you merge the branch and deploy it... trying to properly type everything extends the initial migration time likely to a level where management just says no.

[–] alokir 55 points 1 year ago (2 children)

It's a good way to get started, and then incrementally type as much as you can, preferably everything.

Later on, or if you start a new project with TypeScript, it's a good idea to turn on noImplicitAny and only allow explicit any in very specific framework level code, unit tests or if you interface with an untyped framework.

The hassle really pays off later.

[–] fusio 21 points 1 year ago

this is terrible advise - you should be using unknown. using any you're basically disabling TS and will be under the false assumption that your code is ok while it's most likely missing a lot of runtime checks

[+] [email protected] -11 points 1 year ago* (last edited 1 year ago) (2 children)

But if your code ever integrates with javascript you still need any everywhere so it's pretty pointless

[–] 9point6 13 points 1 year ago* (last edited 1 year ago) (1 children)

Not true, in the absolute worst case, unknown is what you should be reaching for, but it's pretty rare that you can't create some kind of type to interface with JS if it's not already got types. You can even use jsdoc comments as type hints in the JS too if you own that code.

My not particularly hot hot-take: There's basically no legitimate use case for any apart from "I don't have time to type all this now, because I'm converting a massive project from JS to TS"

[–] [email protected] 5 points 1 year ago (1 children)

There are some cases where any must be used instead of unknown but they usually involve generic constraints and seem more like a bug than intended behavior

[–] 9point6 2 points 1 year ago

Ah you're right there, and I also agree, that feels more like a bug than by design

[–] alokir 4 points 1 year ago

Not necessarily, depending on your situation you can type the JS code yourself.

If the team making the JS code were using jsdoc then the Typescript compiler can recognize the comments and use it for type checking.

In some instances the compiler can infer types from JS code to do some basic validation.

Even if the external JS code is recognized as any, your own code that's using it still has types, so it's better than nothing.

[–] [email protected] 11 points 1 year ago (1 children)

an any

[–] some_designer_dude 8 points 1 year ago

But it’s “a colon any” 🧐

[–] [email protected] 7 points 1 year ago

I knew my any key would be useful one day.

[–] topinambour_rex 2 points 1 year ago

Why not use assembly ?

[–] [email protected] 2 points 1 year ago

Typing < type hinting

[–] ABC123itsEASY 1 points 1 year ago

Nah this isn't the way, friend. Instead of adding a bunch of useless anys all over the place, start typing in one part of the application and exclude the rest using a path pattern. Or simply allow .js and only change the extension for files you've typed. Doing this is just wasting time and creating false assurances of type safety.
It's not that hard to define correct, meaningful types. Often vscode already has implicitly determined them for you; just mouseover the variable.

[–] [email protected] -3 points 1 year ago

I wish I did that, at this point my TypeScript template errors are as long as C++'s ._.

[+] beckerist -20 points 1 year ago (3 children)

[deleted]

[–] fibrechips 33 points 1 year ago

Ah yes, node, the JS runtime that very famously doesn't ever get used with typescript

[–] alokir 18 points 1 year ago (1 children)

Typescript is a language, Node is a platform and framework. You can use Typescript in your Node project, they're not mutually exclusive.

The way I see it Typescript is more popular than ever, almost all (popular) libraries come with types and every job offer I get they use Typescript.

And with good reason, our team recently took over a small Javascript app and there are tons of bugs that would never have existed if they were using Typescript. Things like they refactored something but missed to update a reference, or misspelled a variable name, failed to provide a required parameter to a funcrion, referenced a field that existed in another config object etc.

[–] kautau 5 points 1 year ago* (last edited 1 year ago) (1 children)

And thankfully we might be getting to a point where TS no longer needs to exist: https://github.com/tc39/proposal-type-annotations

It’s about time JS gave us the ability to be strict on types, and have that as part of the interpreter as opposed to needing to transpile TS with the overhead involved

[–] [email protected] 5 points 1 year ago (2 children)

Managing a node project is like juggling twelve barrels full of monkeys... and those monkeys have rabies. Trying to keep all your dependencies in line is insane.

[–] [email protected] 4 points 1 year ago

Just use npm to install all the dependencies. What's the worst that can happen.

[–] [email protected] 2 points 1 year ago

It is absolutely insane to me that people rag on the Python packing ecosystem when TypeScript exists. Sure, Python's not perfect (Rust and Go seem better, from the small amount I've dabbled with them), but way easier and more stable than any TS project I've worked on.