this post was submitted on 22 Jul 2023
26 points (86.1% liked)

Selfhosted

40463 readers
402 users here now

A place to share alternatives to popular online services that can be self-hosted without giving up privacy or locking you into a service you don't control.

Rules:

  1. Be civil: we're here to support and learn from one another. Insults won't be tolerated. Flame wars are frowned upon.

  2. No spam posting.

  3. Posts have to be centered around self-hosting. There are other communities for discussing hardware or home computing. If it's not obvious why your post topic revolves around selfhosting, please include details to make it clear.

  4. Don't duplicate the full text of your blog or github here. Just post the link for folks to click.

  5. Submission headline should match the article title (don’t cherry-pick information from the title to fit your agenda).

  6. No trolling.

Resources:

Any issues on the community? Report it using the report flag.

Questions? DM the mods!

founded 2 years ago
MODERATORS
26
PHP and security (self.selfhosted)
submitted 1 year ago* (last edited 1 year ago) by witten to c/selfhosted
 

The recent post about what people are using for webmail got me thinking about a perhaps irrational policy I have with my own self-hosted software: I don't install anything written in PHP, because I have this vague notion that PHP software is often insecure. I think I probably got this idea because years ago I saw all the vulnerabilities in PHP webmail clients and PHP software like Wordpress and decided that it was the language's fault—or at least a contributing factor.

Maybe this isn't fair. Maybe PHP is just more accessible to new devs and so they're more likely to gravitate to it and make security mistakes. Maybe my perception isn't even accurate, and webmail / blog software written in other languages is just as bad—but PHP gets all the the negative attention because it's so prevalent for web apps. Maybe my policy was a good idea, years ago, but now it's just out of date.

To be clear, I'm not trying to stoke the flames of a language holy war here or anything. I'm honestly asking: Is it maybe time to revisit my anti-PHP policy? I'm looking longingly at some federated software like Pixelfed and wondering if maybe I'm just being a little too close-minded.

So I'm interested in your own experiences and polices here. Where do you draw the security line for what you will or won't host, and what made you make that choice?

top 26 comments
sorted by: hot top controversial new old
[–] LrdThndr 47 points 1 year ago (2 children)

I’m a full time senior PHP/JS developer.

PHP has a bad rap because of a few factors.

1, as you said, it’s accessible. It’s a very easy language to learn with a simple syntax and a simple tool chain. So often, it’s a dev’s first language. PHP holds your hand a little bit, but for the most part, security is on the developer, and when a dev doesn’t know any better, bad practices like interpolating values directly into your sql query seem like an easy way to get the job done, but at the hidden cost of opening up SQL injection vulnerabilities. But I’ve seen the same thing happen in Python code, so that’s not really a PHP problem so much as an education problem.

2, earlier versions of PHP were, in a word, shit. They were rife with inconsistencies, poor structure, half-baked features, and it all ran like dogshit. Even today, there’s still some contention in the PHP world about whether to fix the inconsistencies or not, because so much legacy code would fall apart if they did. PHP <= 4 was a goddamned dumpster fire. 5 was MARGINALLY better and brought in proper OOP. 6 literally didn’t exist for various reasons. 7 was actually getting pretty good, now with optional static typing. 8 is BANGIN’. It’s fast, easy to work with, has a great feature set, and a huge community.

3, it’s a big player. When you’re a huge player, you’re also a huge target. Wordpress is one of the most prolific web apps in existence, and it’s PHP based. Being huge, many more people are writing (shit) code for it, and many more (shit) people are trying to break it. Of course software that’s run on more servers is gonna be attacked more. It’s just numbers.

TBH, today, working in both languages extensively, I’d gladly take a PHP based web app over a NodeJS based web app. Don’t get me wrong, I love node for what it is and the paycheck I get, but JS is a goddamned dumpster fire of a half-baked language.

So tldr, don’t fear the PHP. As long as your software was written by somebody who knows their aaS from a hole in the ground, you’ll be fine.

[–] witten 9 points 1 year ago* (last edited 1 year ago)

Lol, I really appreciate your thoughts! These are exactly the sort of insights I came here for. I hope this is useful to others too who may be wondering about the same thing.

[–] [email protected] 3 points 1 year ago

The fact that people still stuck talking about baggages of PHP 4/5, which was released in 2000, as if they’re still valid today is hilarious to me.

[–] [email protected] 17 points 1 year ago (1 children)

Bad applications full of security flaws can be written in basically every language.

The thing with PHP is there's still extremely old apps that just haven't been updated to modern standards, because PHP itself is much older and thus predates more modern JavaScript/Ruby/Python apps. Wordpress in particular hasn't changed all that much, and insists on using a wildly outdated database layer on the name of remaining compatible with old plugins, because those plugins is what people turn to Wordpress for.

As with any app you don't completely trust, the solution is to restrict what they can do as much as possible. Run with minimum privileges, sandbox it in a container, whatever is needed.

[–] witten 2 points 1 year ago

That makes sense. Maybe then the trick is to look at whether any particular app (PHP or otherwise) is written with modern security practices. How do you judge a project's security practices though?

And then, yeah, maybe also lock it down in a container so the blast radius of any actual exploit is pretty minimal.

[–] [email protected] 14 points 1 year ago (1 children)

I wrote my personal website in PHP, and I'm pretty happy with the security I've got going on. I'm not an expert, but I paid close attention to best practices to avoid pitfalls like SQL injection. My instinct is that it's certainly easy to code insecure applications in PHP (and probably many other languages as well), but the language does provide means by which to code safely.

[–] witten 1 points 1 year ago (2 children)

Awesome, good to hear from an actual PHP dev. I assume then you're also fine self-hosting third-party PHP applications? How do you make the call on whether it's okay to host from a security perspective? The same as with software written in any other language?

[–] [email protected] 5 points 1 year ago (1 children)

It's a good idea to invest time into hosting all your stuff in individual containers. You get lots of benefits that way, on top of isolation.

[–] witten 1 points 1 year ago

Totally. Preachin' to the choir here. :D

[–] [email protected] 2 points 1 year ago (1 children)

If I'm being honest, I've never even looked to see what language most of the stuff I run is written in. Out of 16 apps that I'm running, only 3 are accessible from outside my LAN. Those three are high-profile open source projects that are actively maintained. That's enough for me to be comfortable security-wise in my environment.

[–] witten 1 points 1 year ago

Fair enough!

[–] carbonara 12 points 1 year ago* (last edited 1 year ago)

Security flaws are on the programmer, not the programming language. PHP is easy to learn and has many built in functions useful for web developing, but if the programmer doesn’t know anything about security and ships trash code it’s only his fault, this is why Laravel is so popular

[–] SheeEttin 11 points 1 year ago (1 children)

Being worried about software written in PHP is like being worried about buildings built with Ryobi tools.

[–] witten 2 points 1 year ago

I'm not sure that analogy quite holds (it's not like the Ryobi tools are left connected to the building as a critical component of the HVAC system or something), but I like the image anyway. :D

[–] Lemzlez 9 points 1 year ago (1 children)

I don’t think programming language is a good metric for security. I assume everything I host has issues, and then try to mitigate from there.

IMHO, a better approach is to vet the project beforehand, looking at whether it is still actively maintained. I usually use things like commits, issues, etc to try and gauge whether a piece of software is actively maintained so that when an issue arises, it can be fixed.

You can mitigate much of the risk by using some basic best practices, like isolating all apps from each other (using docker, for example), using a reverse proxy, tools like fail2ban or a web application firewall, using proper database permissions for each app, etc

What I also do is add another layer by making certain applications accessible only over vpn. That won’t work for some tools, obviously, but also reduces the risk for tools you are only using yourself.

[–] witten 1 points 1 year ago

That all seems prudent and reasonable. I guess some of my own anxiety is about how exactly I'll evaluate projects like you're talking about. I can (and do) certainly look at whether a project is actively developed before selecting it. Not just for security reasons.. I don't want to bet on a horse that won't get updated with fixes and features. But for security in particular, I guess I was hoping for ways to evaluate that for a project.. without exhaustively poring over its source. Maybe, to your point, the other mitigations you listed should be sufficient, and I should worry more about that side of things than picking the perfect project.

[–] [email protected] 6 points 1 year ago

This is the same as assuming anything written in Rust is secure. (i.e. it's very wrong)

[–] [email protected] 4 points 1 year ago (1 children)

I have a background (in the distant past) as a PHP dev, and currently make my income doing mostly Wordpress work.

For a very long time I took a jaundiced eye towards big PHP apps for the exact same reasons. That being said, I just two days ago finally installed Nextcloud in my homelab and exposed it to the world.

It's worth noting that a lot of PHP's bad rep comes from Wordpress, which is terrible in security terms in large part due to a huge and very poorly vetted ecosystem of plugins written by coders of all skill levels.

PHP itself had a number of anti-features which made security difficult in the past. A lot of those issues have been worked on. As somebody who was up to my eyeballs in PHP for years during the bad old days, I'm now confident installing big PHP apps if I think the dev team and dev process are reasonably mature.

[–] witten 1 points 1 year ago

Good to hear that many of PHP's "bad old days" issues have been fixed. That lines up with what other commenters here have said. I actually wrote some PHP way back then but not since, and I think that may have unfairly colored my current-day views on the language.

[–] [email protected] 3 points 1 year ago* (last edited 1 year ago)

Language itself is not the problem. The old notion of “PHP is insecure” stemmed from languages elitists trying to fan the language war by pointing at CVE repositories and claiming the large number of issues stemming from 3rd party WordPress plug-ins and alike, ignoring the fact that there were way more projects than other languages because it is the most commonly used language on the web, as well as having way longer lineage therefor more time to accumulate security issues; whereas their new and shiney with lesser projects are allegedly more secure because there’s lesser projects, lesser eyeballs, lesser histories, etc.

The core language itself is fine; and just as with any other language out there, it is prudent to keep up with updates. The big named projects are fine; and just with any other projects out there, it is prudent to keep up with updates. The extensions/3rd party modules are … well you get the idea.

Just thought of this comparison:

How would you think if someone tells you “Microsoft (PHP) is insecure because there’s all these 3rd apps (plugins) for Windows (WordPress) that has security issues. Don’t believe me? Just look at all those problems from Windows ME (PHP4/5) days!”

[–] [email protected] 1 points 1 year ago* (last edited 1 year ago) (2 children)

Language where use of uninitialized variable is warning ( not a core dump) should not be used. IT mostly in the past for modern PHP, but bad programmers habits remains. I have seen so horribly written PHP project, so i prefer to stay away.

[–] martijn 3 points 1 year ago

Easy solvable. Develop in strict mode with all notices enabled. Should be the default for any developer.

[–] witten 1 points 1 year ago (1 children)

Thanks for weighing in. That's historically been my take as well, although as of this thread I'm starting to wonder if modern PHP can be better and/or particular projects can be.

[–] [email protected] 1 points 1 year ago

My opinion that language have changed, but people who use it are mostly same. Anyone who starting working in WebDev now will not use PHP, it is no longer a good tool. Like perl, it is still around, lots of software depends on it. But hardly any new stuff will be written on it. And it is programmers who define quality of the code, if you learn to code on language which promote bad practice it is really hard to change.

[–] Kilamaos 1 points 1 year ago (1 children)

Is what you host publicly accesible? If not, then it's not even a concern. You could even host unsafe apps, but if you know they are entirely inaccessible, it wouldn't change a thing.

As for php itself, it's mostly due to the fact it's by far and wide overwhelmingly crushing the competition. A quick Google search says it's used by about 80% of websites. So, it has, by far, the most (negative) publicity, biggest target, and most inexperienced/bad devs working on it. Software is as secure as its made. Junior dev don't often think about security. It's bigger, so it happens more often.

[–] witten 2 points 1 year ago

Yeah, publicly accessible in that it'd be reachable over HTTPS from the internet (and not behind a VPN), but password-protected. Thanks for weighing in on this!

load more comments
view more: next ›