Programming

17655 readers

265 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Follow the programming.dev instance rules
Keep content related to programming in some way
If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities [email protected]

founded 2 years ago

MODERATORS

[email protected]

How common is it to code review like this? (programming.dev)

submitted 9 months ago* (last edited 9 months ago) by [email protected] to c/[email protected]

39 comments fedilink hide all child comments

For non-trivial reviews, when there are files with several changes, I tend to do the following in Git:

Create local branch for the pr to review
Squash if necessary to get everything in the one commit
Soft reset, so all the changes are modifications in the working tree
Go thru the modificiations "in situ" so to speak, so I get the entire context, with changes marked in the IDE, instead of just a few lines on either side.

Just curious if this is "a bit weird", or something others do as well?

(ed: as others mentioned, a squash-merge and reset, or reset back without squashing, is the same, so step 2 isn't necessary:))

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 2 points 9 months ago* (last edited 9 months ago)

Ooh yeah PR as patches, persistent despite rebases, would be nice.

Many git operations fundamentally have three SHAs as parameters (tree operations after all), and GitHub's model simplifies it down to two.