Rust

6111 readers

10 users here now

Welcome to the Rust community! This is a place to discuss about the Rust programming language.

Wormhole

[email protected]

Credits

The icon is a modified version of the official rust logo (changing the colors to a gradient and black background)

founded 2 years ago

MODERATORS

[email protected]

-54

Pretty critical PR for rust-msi is getting held up because the maintainer understands the intent but not why this works (github.com)

submitted 8 months ago* (last edited 8 months ago) by [email protected] to c/[email protected]

13 comments fedilink hide all child comments

Not to throw shade, just wishing that somebody here can understand. Whenever an input is reasonably long, an analyzing function will crash, and this PR aims to fix that with a mechanism that contradicts the maintainer's understanding while a similar C implementation does not need this fix. ~~Clearly, the maintainer has not heard a certain programming mantra...~~

you are viewing a single comment's thread
view the rest of the comments

[–] Solemarc 26 points 8 months ago

What mantra? I think this maintainer is doing the right thing here by trying to understand why this fix works.

You should always attempt to address the root cause of an issue instead of slapping band aid patches onto everything.

To me it looks like the maintainer is trying to find out what exactly is wrong. "this doesn't happen in our C implementation" implies that there's something wrong with the rust code specifically.