Rust

6111 readers

15 users here now

Welcome to the Rust community! This is a place to discuss about the Rust programming language.

Wormhole

[email protected]

Credits

The icon is a modified version of the official rust logo (changing the colors to a gradient and black background)

founded 2 years ago

MODERATORS

[email protected]

-54

Pretty critical PR for rust-msi is getting held up because the maintainer understands the intent but not why this works (github.com)

submitted 8 months ago* (last edited 8 months ago) by [email protected] to c/[email protected]

13 comments fedilink hide all child comments

Not to throw shade, just wishing that somebody here can understand. Whenever an input is reasonably long, an analyzing function will crash, and this PR aims to fix that with a mechanism that contradicts the maintainer's understanding while a similar C implementation does not need this fix. ~~Clearly, the maintainer has not heard a certain programming mantra...~~

you are viewing a single comment's thread
view the rest of the comments

[–] Giooschi 11 points 8 months ago (1 children)

while a similar C implementation does not need this fix

No, that implementation also needs the fix. It's just that it was never properly tested, so they thought it was working correctly.

[–] [email protected] -2 points 8 months ago* (last edited 8 months ago) (1 children)

They tested the same strings on that implementation., though judging by the recent comments someone’s found something.

[–] Giooschi 7 points 8 months ago

They tested the same strings on that implementation

The strings were the same, but not the implementation. They were testing the decoding of the strings, but the C function they were looking at was the one for encoding them. The decoding function was correct but what it read didn't match the encoding one.

though judging by the recent comments someone’s found something.

Yeah, that's me :)