this post was submitted on 02 Jul 2023
1215 points (98.4% liked)

Programmer Humor

19813 readers
460 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 2 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[โ€“] fusio 39 points 1 year ago (4 children)

That's why PR should be small. It's much better to have multiple PRs than a single big one.

Totally fair to have gigantic PR full of boilerplate code, but generally you can split the boilerplate and your feature in 2 PRs, where only the feature will get a proper review.

All of this obviously depends on the criticality of the system :p

[โ€“] Rikudou_Sage 10 points 1 year ago

Or split them per commit at the minimum if you don't want to create a separate PR.

load more comments (3 replies)