this post was submitted on 20 Oct 2023
569 points (97.8% liked)

Programmer Humor

32562 readers
1181 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

founded 5 years ago
MODERATORS
 
  • Adding a line: ✅
  • Removing a line: ✅
  • Modifying a line: ✅
  • Moving a codeblock: ❌ i see you've rewritten everything, let me just highlight it all.

RIP reviewers on my PR.

(Meme created by my coworker)

you are viewing a single comment's thread
view the rest of the comments
[–] killeronthecorner 34 points 1 year ago (4 children)

I'm convinced there must be a way of using ASTs to do more intelligent diffing of a given programming language, but I'm far too lazy to find out for myself.

[–] omidmnz 51 points 1 year ago (1 children)
[–] killeronthecorner 25 points 1 year ago (1 children)

Hell yeah, being lazy paid off. Thanks.

[–] omidmnz 7 points 1 year ago

You're welcome. And have fun trying to break it!

[–] [email protected] 11 points 1 year ago

There is, but your dif tool would have to be language aware and likely be slower to show difs.

[–] [email protected] 6 points 1 year ago

There have been some attempts at semantic diffs, but it’s very uhh… difficult to gain traction with such a thing.

[–] [email protected] 5 points 1 year ago (1 children)

Diffing algorithms on trees might not be as efficient, especially if they have to find arbitrary node moves.

[–] killeronthecorner 2 points 1 year ago (1 children)

I wouldn't expect it to be, but I think modern processors can handle the load!

[–] [email protected] 2 points 1 year ago (1 children)

It's not necessarily about the load, it's about the algorithmic complexity. Going from lists (lines in a file, characters in a line) to trees introduces a potentially exponential increase in complexity due to the number of ways the same list of elements can be organized into a tree.

Also, you're underestimating the amount of processing. It's not about pure CPU computations but RAM access or even I/O. Even existing non-semantic diff implementations are unexpectedly inadequate in terms of performance. You clearly haven't tried diffing multi-GB log files.

[–] killeronthecorner 1 points 1 year ago* (last edited 1 year ago) (1 children)

Log files wouldn't fall under the banner of compiled languages or ASTs, so I'm not sure how that example applies.

And I'm aware that it can lead to O(n²) complexity but, as others have provided, there are already tools that do this, so it is within the capabilities of modern processors

Yes there will be cases where the size of the search space will make it prohibitive to run in reasonable times but this is - by merit of the existing tools and the fact that they seem to work quite well - an edge case.

[–] [email protected] 0 points 1 year ago

Log files themselves don't, but I'm just comparing it with simpler files with simpler structure with simpler algorithms with better complexity.