literally this lol
klin
joined 1 year ago
even better.. if you're a constant refresher like me do top + 3hr
man i see u everywhere otome chan! (not in a bad way)
love that the community is so active :D
would be awesome if we could get this integrated natively — do u wanna open a PR or issue to get this in?
i have a code change request upon for EXACTLY this! talked about it more in another thread: https://kbin.social/m/kbinMeta/t/15413/Collapse-comment-thread#entry-comment-63906
TBH that's not too hard to do, but it goes back to the whole mobile friendliness :(
IMO i think the upside of mobile friendliness outweigh the times people accidentally tap on touchpad, and i personally think just having the header being a touch target is a little too small for mobile users.. so i prefer the whole comment being a target
obviously if folks disagree heavily i could probably adjust but i'm curious what @ernest thinks
interesting, sounds closer to a complete redesign on how we see and interact with the comment – i mostly use apollo so i kinda took the design language there but def see what you're saying!
limiting my change to specifically comment thread collapsing since that sounds like a bigger overhaul!
I love the huge touch target for mobile friendliness, and I've done some work to make sure accidental collapses don't happen (if you mean to select text it won't collapse, if you click on a link or a button it won't collapse either!)
is there a common situation where you'd accidentally collapse stuff when you dont mean to?
SOOOOOO after finally setting up my kbin dev environment I went ahead and wrote some code to add support for EXACTLY this on the official kbin codebase!
GIF of it in action:
demo
I have a PR up for it already here: https://codeberg.org/Kbin/kbin-core/pulls/167
Now just need @ernest 's approval and once it's merged you'll be able to do this on kbin without any modifications!!!
edit: clicking on a comment now also hides its content (other than the username), making it even more clear which threads are collapsed! (similar to apollo) – updated the demo gif
after some digging i found that you can get this under settings > subscriptions — IMO not super intuitive and i wish there was a way we could get there quickly from the sidebar like apollo
yup that’s me! it’s gone through several reviews and i envision it to hopefully go in once ernest has some time to breathe!
if u want to see gifs of it in action: https://codeberg.org/Kbin/kbin-core/pulls/167