this post was submitted on 01 Mar 2025
20 points (88.5% liked)

Programming

18472 readers
118 users here now

Welcome to the main community in programming.dev! Feel free to post anything relating to programming here!

Cross posting is strongly encouraged in the instance. If you feel your post or another person's post makes sense in another community cross post into it.

Hope you enjoy the instance!

Rules

Rules

  • Follow the programming.dev instance rules
  • Keep content related to programming in some way
  • If you're posting long videos try to add in some form of tldr for those who don't want to watch videos

Wormhole

Follow the wormhole through a path of communities [email protected]



founded 2 years ago
MODERATORS
 
 # Ask user to enter an expression and display output
def main():
    expression = input("Expression: ")

    print(calculate(splitter(expression)))


# Split expression into components and assign to variables as float values
def splitter(expression):
    x, y, z = expression.split()

    return x, y, z

# Calculate expression result
def calculate(x, y, z):
    x, z = float(x), float(z)

    if y == "+":
        return str(round((x + z), 1))
    elif y == "-":
        return str(round((x - z), 1))
    elif y == "*":
        return str(round((x * z), 1))
    else:
        return str(round((x / z), 1))



main()

I am getting traceback errors for any expression (1 + 1) I enter.

top 13 comments
sorted by: hot top controversial new old
[–] rtxn 22 points 2 days ago* (last edited 2 days ago)

Change this:

    print(calculate(splitter(expression)))

to this:

    print(calculate(* splitter(expression)))

The error is that calculate expects three float values (x, and y, and z), but splitter returns a tuple object ((x, y, z) as one object, similar to arrays in other languages):

>>> type(splitter("1 + 2"))
<class 'tuple'>

Prepending a tuple or a list with a * operator (unpacking or splatting) unpacks the object into its individual items that are then passed to the function as separate arguments.

In fact, str.split() already returns a tuple. By assigning multiple values at once in x, y, z = expression.split(), you actually unpack the returned tuple into individual values, then in return x, y, z, you pack those values into a tuple.

[–] [email protected] 6 points 2 days ago

There's a [email protected] community more appropriate to python specific questions

[–] [email protected] 5 points 2 days ago

print(eval(input("Expression:")))

Unsafe coding is best coding ;)

[–] [email protected] 6 points 2 days ago* (last edited 2 days ago) (1 children)

Functions in Python can only return a single value. While you are allowed to comma-separate additional values, as you have done, they are combined into a single tuple object that wraps the intended values.

As such, your splitter function is returning a single tuple containing three strings. Your calculate function is expecting three individual arguments (I'm guessing that the error trace mentions this).

To get around this, you can use the splat/asterisk operator to "unpack" the items from the tuple:

a, b, c = splitter(expression)
# or, inline
calculate(*splitter(expression))

Edit: removed bad asterisk

[–] eager_eagle 7 points 2 days ago* (last edited 2 days ago) (1 children)

Functions in Python can only return a single value

that's not ~~true~~ accurate, this is valid code in this context:

x, y, z = splitter(expression)

Where x, y, and z are strings. But when you do this, akin to what OP did:

value  = splitter(expression)

then value is a tuple of 3 strings.

In fact, unpacking with asterisk at assignment, like below, is not allowed:

x, y, z = *splitter(expression)
    x, y, z = *splitter(expression)
              ^^^^^^^^^^^^^^^^^^^^^
SyntaxError: can't use starred expression here
[–] [email protected] 2 points 2 days ago

Gahh, serves me right for blindly writing code on my phone!

[–] [email protected] 3 points 2 days ago (1 children)

Yeah others have pointer out the error, but I want to really recommend using VSCode with the Python extension and static types. It will make finding these errors super easy because it adds a red underline exactly where the problem is.

Static types means:

def splitter(expression: str) -> tuple[str, str, str]:
...
def calculate(x: str, y: str, z: str) -> str:
[–] [email protected] 4 points 2 days ago (1 children)

PyCharm is the way to go to write Python.

[–] [email protected] 1 points 2 days ago* (last edited 2 days ago) (1 children)

Yeah that's a great option too. Not free though (although the pricing is very reasonable IMO). I think if you're this much of a beginner it doesn't make sense to pay for Pycharm.

[–] [email protected] 4 points 2 days ago (1 children)

The community version is free right

[–] [email protected] 1 points 2 days ago

Ah yeah I don't think that existed last time I used it.

[–] [email protected] 2 points 2 days ago* (last edited 2 days ago)

After the split x becomes (1 and z becomes 1). They can't be converted to float. I think that's why. Let me run the code. Edit - Also as you are returning a, b, c from splitter but Python functions return a single object. The a, b, c turns to a tuple. But you are using js syntax I think. So we have to unwrap inside the calculate function.

Now my original comment is not useful but you can try to introduce a conditional to check of the numbers x and z are actually numbers before converting to floats

# Ask user to enter an expression and display output

def main():
    expression = input("Expression: ")
    print(calculate (splitter (expression)))

# Split expression into components and assign to variables as float values

def splitter (expression):
    print(expression)
    x, y, z = expression.split()
    print(expression.split())
    return x, y, z

# Calculate expression result

# Changes Beginning
def calculate(numbers):
    x,y,z = numbers
# Changes End

    x, z = float(x), float(z)
    if y == "+":
        return str(round((x + z), 1))
    elif y == "-":
        return str(round((xz), 1))
    elif y == "*":
        return str(round((x*z), 1))
    else:
        return str(round((x / z), 1))

main()

[–] eager_eagle 1 points 2 days ago* (last edited 2 days ago)

you're missing the asterisk to expand the tuple returned by splitter:

print(calculate(*splitter(expression)))

if you're using VS Code, check out the error lens extension