So, over on the subreddit there's a post that caught me off guard. I'm not experienced enough with the game to know the ins-and-outs of all of classes, so when someone posted asking about Ruffian Rogues and Picks.
From the comments, this appears to be a Thing of Great Contention within the Pathfinder space (or, at least within that Pathfinder space; I find r/Pathfinder2e to be a rather... idiosyncratic place, personally).
The long and short of it is that Picks have the Fatal d10 trait, but Ruffian specifies:
You can deal sneak attack damage with any weapon, not just the weapons listed in the sneak attack class feature. This benefit doesn't apply to a simple weapon with a damage die greater than d8 or a martial or advanced weapon with a damage die greater than d6. (Apply any abilities that alter the damage die size first.)
(Emphasis mine.)
A lot of words have been published over how the Ruffian doesn't lose Sneak Attack on a critical hit, but this seems pretty straight forward from the text here that it does. Weird and stupid, and something I'd never personally enforce, but clear and straight forward nonetheless.
This is the updated wording from Player Core 1, no less, and Ruffian's text was updated in the remaster, so there was an opportunity to reword or clarify that was not taken, so I'm not sure what others are reading from this that I'm not.
How do you interpret this situation? How would you judge it at your table?
I think this largely depends on whether you consider traits abilities or not. My interpretation would be that abilities are things like class features/feats, but traits are not, and would therefore not impact the ruffian’s sneak attack specifically.
Why do you interpret that way? That's the only way I can make this make sense, but that seems totally arbitrary. The text could say "character feat" if that's what they meant.
The Fatal feat grants the weapon the ability to use a higher damage die, so the word is poorly chosen if it's meant to be viewed as narrowly defined.
I think they meant for it to cover more than just feats. For instance, maybe you have an item you activate that increases your damage die size or you’re under the effects of a spell. It would be too verbose for them to enumerate everything. They could have instead stated “effect” or “anything” if they intended it to cover traits. There is also this from the definition of trait (emphasis mine):
Trait specifically calls out ability as something separate from a trait.
But here, trait is calling itself out as a word. In this case, it's a word that signals an ability that originates from the item.