this post was submitted on 10 Mar 2024
44 points (97.8% liked)

Summit

741 readers
8 users here now

Community to discuss Summit, a Lemmy reader for Android.

App (Play Store): https://play.google.com/store/apps/details?id=com.idunnololz.summit

APK: https://github.com/idunnololz/summit-for-lemmy/releases

Patreon: https://patreon.com/SummitforLemmy

Ko-Fi: https://ko-fi.com/summitforlemmy

Website: https://summit.idunnololz.com/

founded 1 year ago
MODERATORS
44
submitted 8 months ago* (last edited 8 months ago) by idunnololz to c/summit
 

This update adds notifications support to the app. Notifications will need to be enabled on a per-account basis to reduce the amount of unnecessary API calls. You can find notifications & their per-account settings in Settings > Notifications. By default notifications are disabled.

When notifications are enabled, you will get notified of any unread DMs, mentions or replies to your posts. In addition, if you are an admin or mod, you will also get notified of reports.

Like previous updates, this update also adds a lot of quality of life improvements such as better video support and bug fixes. See the full change log for details.

Due to notifications being a big change, this release will be rolled out slowly over the next two days to reduce the impact of bugs on users.

Full change log

  • Added notifications as an optional feature to the app. This feature is off by default. To enable, go to Settings > Notifications.
  • Added support for RedGifs.
  • Added more options in the built-in video player.
  • Changed the comment screen to auto focus the input field when first shown.
  • Fixed an issue where custom comment gesture actions where not being applied.
  • Fixed a regression with screenshot mode where post actions are not hidden when in screenshot mode.
  • Fixed some inconsistent scrolling behavior throughout the app.

Update

Rollout complete. There is one minor bug found but it was very minor so I will punt for next update. The bug is, if you tap on a notification, it will take you to the message in your inbox, however when you go back (to your inbox) the message looks like its not read yet. This is a client side bug only; the message is correctly marked as read on the server.

Update 2

There is a very minor update for the Github release to fix a crash that is only present in the Github release (there was some code that had undefined behavior so the Github and PlayStore versions had different behavior despite being compiled from the same code). Thus the Github release is v1.29.1.

you are viewing a single comment's thread
view the rest of the comments
[–] idunnololz 2 points 8 months ago (1 children)

Could you send me your settings configuration? This will help me debug the issue as the crash does appear to occur under normal circumstances. You can get it by going to Settings > Import & export settings > Export settings. Then tap copy to clipboard. You can send it to me here or DM me.

[–] [email protected] 2 points 8 months ago (1 children)
[–] idunnololz 2 points 8 months ago

Ah actually I finally got a reproduction. It turns out, parts of my code has undefined behavior. So compilation of the code in these part is not well defined. Eg. each time the code is compiled it can do A or B and both are technically correct interpretations of the code.

This means that I can change nothing about my code and technically we can see one release do A and another do B. In this case, the play store release is actually fine but the github release is not. In addition, the previous versions are fine and this release isn't even though the logic didn't change. I have a fix planned and I will do a release soon. Since this issue only affects the github release, I do not need to do a release for the play store version.