Memes

45661 readers

1264 users here now

Rules:

Be civil and nice.
Try not to excessively repost, as a rule of thumb, wait at least 2 months to do it if you have to.

founded 5 years ago

MODERATORS

[email protected]

376

I was able to learn React though (lemmy.world)

submitted 10 months ago by qaz to c/[email protected]

28 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 3 points 10 months ago (1 children)

It seems like you are implying this is an obvious optimization, regardless of context. Why do we not care what's going on with b?

[–] orgrinrt 6 points 10 months ago* (last edited 10 months ago) (1 children)

Yeah, the two aren’t equivalent and the original has more conditions than the new one, so without context this just doesn’t make sense in this example.

A is “” only when B is also “”, otherwise we return f()

In the new one we simply say that regardless of what B is, we’ll just call f(), entirely skipping the case where B == “”.

Probably this specific condition checking was moved to the inner scope of f(), but this example does not tell us (who don’t know the context) that. Or maybe the check is redundant, but that also isn’t signaled in any way.

Or then maybe I’m just oblivious to the optimization, in which case I can see why the maintainer would take their time figuring that out. It’s not anything obvious based on that alone, at least to me, and I would say I have some experience in this field.

Edit: But yeah this is basically just semantics, I’m sure they gave apt description in the PR, so the context would be explained there and none of this really matters. I just like to ruminate about little things like this for some reason. Didn’t mean to imply they didn’t do a good PR, just that this specific example was either confusing or confused.