this post was submitted on 23 Sep 2023
810 points (98.7% liked)

Programmer Humor

32710 readers
774 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

founded 5 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 15 points 1 year ago (3 children)

Although it's true that you are increasing the attack surface when compared to locally stored OTP keys, in the context of OTPs, it doesn't matter. It still is doing it's job as the second factor of authentication. The password is something you know, and the OTP is something you have (your phone/SIM card).

I would argue it is much worse what 1Password and Bitwarden (and maybe others?) allows the users to do. Which is to have the both the password and the OTP generator inside the same vault. For all intents and purposes this becomes a single factor as both are now something you know (the password to your vault).

[–] [email protected] 11 points 1 year ago (1 children)

That’s not quite right though, there’s the factor you know (password to your vault), and the factor you have (a copy of the encrypted vault).

Admittedly, I don’t use that feature either, but, it’s not as bad as it seems at first glance.

[–] [email protected] 3 points 1 year ago* (last edited 1 year ago) (2 children)

That’s not quite right though, there’s the factor you know (password to your vault), and the factor you have (a copy of the encrypted vault).

That would be true for offline vaults, but for services hosted on internet I don't think so. Assuming the victim does not use 2FA on their Bitwarden account, all an attacker needs is the victim's credentials (email and password). Once you present the factor you know, the vault is automatically downloaded from their services.


This is something I hadn't thought until know, but I guess password managers might(?) change the factor type from something you know (the password in your head) to something you have (the vault). At which point, if you have 2FA enabled on other services, you are authenticating with 2 things you have, the vault and your phone.

[–] [email protected] 4 points 1 year ago (1 children)

Assuming the victim does not use 2FA on their Bitwarden account

A pretty tall assumption given that we're already talking about someone who knows to turn on 2FA for other things. If someone knows about 2FA and password managers, they'd be insane not to have 2FA set up on the password manager itself.

[–] [email protected] 2 points 1 year ago* (last edited 1 year ago) (1 children)

That's a fair point. I just wanted to highlight that there may be cases where a password manager isn't automatically protected by 2FA by the two factors you mentioned (The password you know and the copy of the vault) since in the case of bitwarden fulfilling one can give you the second. In order to actually achieve 2FA in this case, you would need to enable OTPs.

[–] [email protected] 2 points 1 year ago

Certainly fair.

And yeah, I personally use Bitwarden with 2FA on the Bitwarden account, but don't store any 2FA tokens in Bitwarden, handling them all separately. Don't want all the eggs in one basket.

Though given I have fingerprint access on phone and computer for bitwarden, i suppose that one basket is my finger. But if someone is taking my finger, I've got more immediate concerns than my passwords.

[–] [email protected] 3 points 1 year ago

It works for self hosted vaultwarden mostly also. Since you would need a way to acess the login page itself, which could be behind a VPN or other authentication service like Authentik.

[–] [email protected] 3 points 1 year ago

This is why we require second factor on the password manager too, otherwise you’re exactly right.

[–] Rehwyn 3 points 1 year ago* (last edited 1 year ago) (2 children)

Arguably, if you use 2FA to access your passwords in 1password, there's little difference between storing all your other OTPs in 1password or a separate OTP app. In both cases, since both your secret passwords and OTPs are on the same device (your phone), you lack a true second factor. The most likely way someone would gain access to 1password secured with 2FA is if they control your device and it's been compromised, and having your OTPs separated wouldn't provide additional protection there. Thankfully, the larger benefit of OTPs for most people is that they are one-time-use, not that they originate from a second factor.

There is one theoretical situation I can think of where having your OTPs and passwords separate could be an advantage, and that's if someone gained all your 1password login details, including the 2FA secret key. But for someone able to gather that much sensitive intel, I'm not sure how much more of a challenge an authenticator app would be.

If you truly feel you need a second factor though, you'll probably want to look at something like a Yubikey or Titan. I've considered getting one to secure my 1password vault to reduce the risk of a lost phone compromising my vault.

[–] [email protected] 1 points 1 year ago

Arguably, if you use 2FA to access your passwords in 1password, there’s little difference between storing all your other OTPs in 1password or a separate OTP app. In both cases, since both your secret passwords and OTPs are on the same device (your phone), you lack a true second factor. The most likely way someone would gain access to 1password secured with 2FA is if they control your device and it’s been compromised, and having your OTPs separated wouldn’t provide additional protection there. Thankfully, the larger benefit of OTPs for most people is that they are one-time-use, not that they originate from a second factor.

As you said if you have both the password manager and the OTP manager in the same device it goes against the concept of 2FA, and you can throw most of guarantees out the window.

I think one distinction worth making is that the encrypted vault itself is still only protected by one factor, the password. The OTP 1Password asks you is part of their service authentication mechanism. If for some reason the attacker manages to get an encrypted copy of your vault (Via App cache, Browser add-on cache, mitm, 1Password's servers, etc...), "all" the attacker needs is to brute force your password and they can access the contents (Password and OTP seeds) of the vault without requiring the TOPT token. Yes you can mitigate this with a good password/passphrase, but as GPUs/CPUs get faster will that password continue to be good enough in few years time? If your master password becomes "easily" brute forceable, now the attacker has access to all of your accounts because you had the password and OTP seeds in one vault.

If you truly feel you need a second factor though, you’ll probably want to look at something like a Yubikey or Titan. I’ve considered getting one to secure my 1password vault to reduce the risk of a lost phone compromising my vault.

I have one, but unfortunately the amount of services that support U2F as a 2FA mechanism is relatively small and if you want to talk about FIDO2 passwordless authentication even less.

[–] LUHG_HANI 1 points 1 year ago

Get it. Stop procrastinating;-)