this post was submitted on 25 Jun 2023
392 points (97.8% liked)
Programmer Humor
32595 readers
1848 users here now
Post funny things about programming here! (Or just rant about your favourite programming language.)
Rules:
- Posts must be relevant to programming, programmers, or computer science.
- No NSFW content.
- Jokes must be in good taste. No hate speech, bigotry, etc.
founded 5 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
More often than not this is "it seems like there are problems with how it's implemented but I can't think of them now" but sometimes it definitely is "that's not the way I would have done it and therefore wrong"
All that said, I used to work with a guy that would find a reason to fail every code review. It became common for people to add intentional easy mistakes so that the lead could feel like he was contributing.
It could be a legitimate criticism. Sticking to a codebase style and to the language idioms improves clarity and thus maintainability. But then, that means the way to do it should already be clear.
Agreed, and those patterns often have reasons to them, which may not be obvious at first glance, and are often forgotten when your spend a long time with them.